search

GMOD / jbrowse-registry

JBrowse 1.x Plugin Registry
https://gmod.github.io/jbrowse-registry/
BSD 2-Clause "Simplified" License
14 stars 8 forks source link

Update jbrowse #37

Closed cmdcolin closed 7 years ago

cmdcolin commented 7 years ago

This updates the JBrowse version to 1.12.3 :)

cmdcolin commented 7 years ago

Note that this adds a symlink http://gmod.github.io/jbrowse-registry/demos/jbrowse that points to JBrowse-1.12.3 instead of linking to the raw JBrowse version (previously links were to http://gmod.github.io/jbrowse-registry/demos/JBrowse-1.12.1)

The old version 1.12.1 is not removed here because there are links http://gmod.github.io/jbrowse-registry/demos/JBrowse-1.12.1 on other websites currently

nathandunn commented 7 years ago

@cmdcolin Overall I think this is great (we should be using the most recent version). However, I'm wondering if this should be a one-line change to a config switching the tag, then actually changing the files in the repo. We should go forward with this one way or another, just raising the question.

cmdcolin commented 7 years ago

Depends on how much automation needed. Technically it would be really great if we didn't even need a jbrowse copy in this repository. Can almost get there using something like this

http://jbrowse.org/code/JBrowse-1.12.3/?data=https://rawgit.com/gmod/jbrowse-registry/master/demos/gwasviewer

Seems like there are a couple of places where CORS doesn't go through using that technique though

nathandunn commented 7 years ago

Shoot, yeah, that would be a nice way. Not the end of the world if we have to do it this way, though.

cmdcolin commented 7 years ago

Adding this PR into jbrowse would allow the URL format that I was looking at to work https://github.com/GMOD/jbrowse/pull/898

cmdcolin commented 7 years ago

we'll just wait till we can use a remote jbrowse instance, seems better than way. close for now