search

GMOD / jbrowse-registry

JBrowse 1.x Plugin Registry
https://gmod.github.io/jbrowse-registry/
BSD 2-Clause "Simplified" License
14 stars 8 forks source link

Add ColorByType #47

Closed dytk2134 closed 6 years ago

rbuels commented 6 years ago

Could you tweak your license expression to a valid SPDX license expression? It's failing the linting.

ERROR: ColorByType has a non-SPDX license identifier. Please see the list here https://spdx.org/licenses/
dytk2134 commented 6 years ago

Sorry for the late reply. It spend us some time to figure out which license should we use. It seems like the check has failed again. In the license part, I can only put one valid SPDX license there, right?

rbuels commented 6 years ago

You can put multiple licenses there, it just has to be in SPDX license expression. It's a little hard to find readable syntax specifications but I think you can do things like "LIC1 AND LIC2" or maybe "LIC1 OR LIC2"

On Tue, Jul 17, 2018 at 10:50 AM dytk2134 notifications@github.com wrote:

Sorry for the late reply. It spend us some time to figure out which license should we use. It seems like the check has failed again. In the license part, I can only put one valid SPDX license there, right?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GMOD/jbrowse-registry/pull/47#issuecomment-405669118, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEgFSnFpKw8KkvyiPoubnz-Hl9dDCJbks5uHiPpgaJpZM4VNPhe .

rbuels commented 6 years ago

oh i found a readable document about SPDX license IDs in the node.js documentation, see https://docs.npmjs.com/files/package.json#license

Try enclosing your license identifier in parentheses?

dytk2134 commented 6 years ago

Umm...did I do something wrong? license: (CC0-1.0 OR BSD-3-Clause)

awilkey commented 6 years ago

It looks like the current lint command uses spdx-licenses to test the license string for validity, but that particular tool only supports up to SPDX 1.19, when conjunctions were added with the 2.0 specification.

dytk2134 commented 6 years ago

Thanks a lot. It works!