GMOD / jbrowse

JBrowse 1, a full-featured genome browser built with JavaScript and HTML5. For JBrowse 2, see https://github.com/GMOD/jbrowse-components.
http://jbrowse.org
Other
464 stars 199 forks source link

Modify left click pop-up static code in JBrowse version 1.16.3 #1372

Closed thomas77 closed 5 years ago

thomas77 commented 5 years ago

Hello !

On a old JBrowse version I was able to edit the left click pop-up (when clicking on a specific feature like gene for example) to add some static text: you can see this example here.

To do that I duplicated the files "CanvasFeatures.js" and "_FeatureDetailMixin.js" to add this little portion of html code. Then I called these files in my trackList.json file like this: "type" : "JBrowse/View/Track/CanvasFeaturesForWheat"

My problem is that I'm not able to do that with my new version of JBrowse (1.16.3), I saw that these files are called by a bundle.js file that seem's to call all the files from the outside: (function(){(this||window).webpackJsonp.registerAbsMids({"JBrowse/Browser":125,"JBrowse/Util":329,"JBrowse/QueryParamConfigMapper":330,"JBrowse/Model/XHRBlob":331,"JBrowse/Store/SeqFeature":332,"JBrowse/Model/SimpleFeature":333,"JBrowse/Store/DeferredFeaturesMixin".....

Could you please help me to modifiy the files I want ?

Best regards,

Thomas

cmdcolin commented 5 years ago

@thomas77 with the latest version of jbrowse, you have to rebuild the codebase when you make modifications

To setup a development environment with the latest version of jbrowse you can

a) retrieve a git clone of jbrowse e.g. git clone https://github.com/gmod/jbrowse b) add your new files to the source directory c) run ./setup.sh d) run npm run watch which will update the build with your files

cmdcolin commented 5 years ago

Then you simply modify code in another window and refresh browser to see your changes as usual (just leave the npm run watch command running in background)

cmdcolin commented 5 years ago

Also, if you think this change, for example adding an optional header at the top of the view details panel, can be generally useful, feel free to make a pull request!

cmdcolin commented 5 years ago

Let me know if there are any issues, since this is not really a bug or feature request I'll close for now