Closed russellmyers closed 4 years ago
Possible fix here https://github.com/rbuels/http-range-fetcher/pull/7
If you are interested in testing, here is a way you can
git clone https://github.com/rbuels/http-range-fetcher
cd http-range-fetcher
git checkout fix_stat_undefined_error
yarn
yarn build
yarn link
cd ..
git clone https://github.com/gmod/jbrowse
cd jbrowse
yarn
yarn link http-range-fetcher
yarn watch
After yarn watch, jbrowse is rebuilt and you can open the index.html or run yarn start
in the jbrowse folder
Thanks @cmdcolin, will check out the potential fix above and will report back here
Hi @cmdcolin - I've installed a test version as per above. It's here: http://pseudobase-test.biology.duke.edu/jb_rf/jbrowse/?data=pse
However, I'm still able to reproduce the error.
NOTE - I tried putting a breakpoint in httpRangeFetcher.js to ensure it was actually reaching the new code, but something is puzzling me - I must have done something wrong, as the source code in the debugger for httpRangeFetcher.js doesn't seem to match the code on Github. (Caveat: I'm no expert on Dojo, or even Javascript - I have Python/Java background).
For example, the definition of the HTTPRangeFetcher class at the start of the source code of httpRangeFetcher.js is defined in "var ... function()" syntax in the debugger (see second pic below) however it is defined with "class" syntax in the actual master souce code on github. So, I seem to have completely the wrong source code for httpRangeFetcher.js somehow (or else I'm misunderstanding something). What might I have done wrong? Any clues?
Cheers, Russell
@russellmyers I am not seeing the error happen when I visit this link. I can confirm you have the right http-range-fetcher installed there too
Can you clear browser cache and ensure that you are still seeing the error with your updated link?
@cmdcolin Thanks for confirmation of the correct http-range-fetcher installation in the test jbrowse link I set up (jb_rf/jbrowse..). I've tried clearing the cache, and from what I can see the error certainly seems to be happening less, however I can still reproduce the error in certain situations.
For example:
1) Clear cache
3) Then once all tracks are loaded successfully, hit the big zoom out button once.
Result: I still get the "failed to retrieve file size error".
Would you be able to try the above as well? Do you get the same error?
Cheers, Russell
I can reproduce, and can see where there is a possible problem
No fix yet but will keep you posted
Great, thanks @cmdcolin !
@russellmyers if you want to try a new fix
cd http-range-fetcher
git fetch
git checkout perform_record_stats_in_stat
yarn
yarn build
cd ../jbrowse
yarn
yarn watch
This should create a new instance with the new http-range-fetcher incorporated
Excellent, seems to have done the trick! Thanks heaps @cmdcolin
This was fixed on dev branch, pending next release
JBrowse version: JBrowse 1.16.6 Web browser: Chrome (also reproducible in other browsers)
Error encountered "failed to retrieve file size" when browsing through indexed vcf tracks - see attached images.
The issue appears to be very similar to issue #1252 on github (which is marked as closed).
Steps to reproduce: