search

GMOD / jbrowse

JBrowse 1, a full-featured genome browser built with JavaScript and HTML5. For JBrowse 2, see https://github.com/GMOD/jbrowse-components.
http://jbrowse.org
Other
460 stars 199 forks source link

tab focus for accessibility enhancement? #1606

Open mpoelchau opened 3 years ago

mpoelchau commented 3 years ago

Hi Jbrowse team,

We recently had an accessibility expert review the tools that we offer for our database, which includes Jbrowse/Apollo. He comments that, for a visual user that can only keyboard navigate, there is a problem with no visible keyboard focus to show the user where they are in some cases. For example, in the attached screenshots of the jbrowse volvox demo there's a visual focus on the 'Go' button on the top right when I tab to it, then I hit tab twice to get the focus on the 'hide/show track titles' icon, but no focus when you click on the tab again multiple times. He was pleasantly surprised that he was able to tab around, so a visual focus on where the tab is would be a useful next step.

Would you be able to consider some improvements along these lines in the future?

Thanks!

Visual focus on 'Go' icon: Screen Shot 2021-06-11 at 10 19 11 AM

Visual focus on 'hide/show' icon: Screen Shot 2021-06-11 at 10 19 39 AM

No visual focus after tabbing again: Screen Shot 2021-06-11 at 10 19 50 AM

cmdcolin commented 3 years ago

This is good to hear that there is some level of accessibility! It is definitely a very complicated front-end app with a lot of dynamic javascript so it is interesting to know that some small changes could help even more.

It may be hard to dedicate too many resources to updating jbrowse 1 as we are pretty busy with jbrowse 2 but we can keep this open

cmdcolin commented 3 years ago

no focus when you click on the tab again multiple times

I guess to be clear, is there an expectation of where the tab should go after that?

mpoelchau commented 3 years ago

Thanks for looking into this! If it happens in Jbrowse2 rather than 1 that would be great, too. I don't think there's an expectation as to where the tab goes, just that wherever it goes is indicated with a visual focus.