search

GMOD / jbrowse

JBrowse 1, a full-featured genome browser built with JavaScript and HTML5. For JBrowse 2, see https://github.com/GMOD/jbrowse-components.
http://jbrowse.org
Other
460 stars 199 forks source link

can not turn on gradient for neatcanvasfeatures #993

Closed nathandunn closed 6 years ago

nathandunn commented 6 years ago

Went and tested #988 Definitely works well for NeatHTMLFeatures.

For Canvas, I can't get them to turn at all now. The flag seems to be set properly, but it never gets processed.

We should probably also cleanup the doc for both https://github.com/GMOD/jbrowse/blob/dev/plugins/NeatHTMLFeatures/README.md and https://github.com/GMOD/jbrowse/blob/dev/plugins/NeatCanvasFeatures/README.md once they are both working.

We may also want to fix it so the feature options are the name (linearGradient or gradientFeatures, etc.)

nathandunn commented 6 years ago

I thinks I gots a fix for this.

rbuels commented 6 years ago

This is an issue with #988, might have been better to just have this in that thread

nathandunn commented 6 years ago

I would, have but its already merged.

nathandunn commented 6 years ago

I hadn't a chance to test it.

rbuels commented 6 years ago

Sigh I mean #992

nathandunn commented 6 years ago

Ahh . . okay, I'll just put my patch notes and close this.

nathandunn commented 6 years ago

Closing in favor of #992