GMS-SA / roundcube-advanced-search

Advanced Search Plugin for Roundcube
16 stars 19 forks source link

Russian localization and some other issues #10

Closed urusha closed 10 years ago

urusha commented 10 years ago

Here is the russian localization. https://gist.github.com/urusha/9185215

Also, it would be nice to make criteria translatable (for now we have to edit config.inc.php).

Another issue is in the screenshot (Roundcube 1.0-rc, advanced_search 2.1.2, "Show mailbox title as column" is enabled) cols

Thanks for the plugin.

FireFoxIXI commented 10 years ago

@urusha Thanks for your feedback and your translation.

As for the screenshot, indeed in Roundcube 1.0 the html structure changed slightly, so we will need to adapt to this.

As for making the criteria translatable, we will have a look into that.

FireFoxIXI commented 10 years ago

@urusha we found a way to make the criteria translatable.

I forked your russian localization ( https://gist.github.com/FireFoxIXI/9190041 ) and added the additional labels.

Could you please review/complete this gist so we can include those translations in the next update?

Thanks

urusha commented 10 years ago

Here is modified gist: https://gist.github.com/urusha/9190524 I think there should be additional label for "Saved searches:", a nice russian translation for it would be "Сохраненные".

Also, despite there is no classic skin support, it mostly works, except toolbar button: 2014-02-24 20 28 45 ... and "Show mailbox title as column" - it doesn't work at all.

Taking the opportunity, I'd like to request another feature: it would be really nice to have an ability to view saved searches as virtual folders.

Thanks.

FireFoxIXI commented 10 years ago

@urusha Thanks for your feedback, much appreciated.

I integrated your translation and added a label for "Saved searches".

I also added basic classic support, most of the issues were just missing css.

Will need to do some more test before publishing.

FireFoxIXI commented 10 years ago

@urusha could you please check that everything works as expected, if so i will close this issue.

Thanks

urusha commented 10 years ago

I've checked recent stable version:

Thank you so much for your work!

FireFoxIXI commented 10 years ago

@urusha Thanks again for your support.

All this, except the virtual folders has been added to the latest stable version. For the virtual folders i added a new feature request under #12