search

GMS-SA / roundcube-advanced-search

Advanced Search Plugin for Roundcube
16 stars 19 forks source link

All folders search not working properly #4

Closed adamjeelife closed 10 years ago

adamjeelife commented 11 years ago

All folders search not working properly, its showing emails but on double click its failed to open the email and display message "Could not load message from server". If default inbox page is open and I try to search email in all folders which is not in inbox its display above mentioned error "Could not load message from server". I will be very thankful to you if you resolve this issue.

gms-chris commented 11 years ago

We are aware of this problem and are looking into how to resolve it.

This core issue is that the Roundcube JavaScript overwrites the target folder with the current folder and the message is then not found. There is a good chunk of the core code that simply does not work with the concept of a message list displaying the content from multiple folders.

adamjeelife commented 11 years ago

Thanks for your prompt response. I also use Message Label plugin for roundcube that filter emails from all folders but have a limitation to search with limited fields like( Subject, From , To and cc). May be this information will help you to resolve this issue. Download linkhttps://github.com/umount/message_label Regards, Muhammad Faisal Date: Wed, 29 May 2013 02:57:41 -0700 From: notifications@github.com To: roundcube-advanced-search@noreply.github.com CC: mfaisal_2011@hotmail.com Subject: Re: [roundcube-advanced-search] All folders search not working properly (#4)

We are aware of this problem and are looking into how to resolve it.

This core issue is that the Roundcube JavaScript overwrites the target folder with the current folder and the message is then not found. There is a good chunk of the core code that simply does not work with the concept of a message list displaying the content from multiple folders.

— Reply to this email directly or view it on GitHub.

adamjeelife commented 11 years ago

Thanks for your prompt response. I also use Message Label plugin for roundcube that filter emails from all folders but have a limitation to search with limited fields like( Subject, From , To and cc). May be this information will help you to resolve this issue.

Download link https://github.com/umount/message_label

gms-chris commented 11 years ago

Thanks for the link. It looks like you can produce the same error in this plugin in a different way:

Am working on a fix to the advanced_search. Similar solution to the above. You need to overwrite the interfaces idea of what is the current mailbox.

There will still be issues when there are conflicting uid's from different mailboxes. This can be the case. The RoundCube message list does not have any way of dealing with this as far as I can see.

atEverychance commented 11 years ago

@gms-chris Really appreciate your working to resolve the All Folders search bug - Is there anywhere I can donate to a beer fund to help? :)

atEverychance commented 11 years ago

@gms-chris how goes the All Folders results fix efforts? anywhere I can donate to help? really appreciate your working at it! thank you!

gms-chris commented 11 years ago

I have one part working, that is the display of the correct message. There is still the outstanding issue of conflicting UIDs in the list. I am not sure I wish to do what was done in the message_label plugin here. Looking at an alternative.

atEverychance commented 11 years ago

@gms-chris awesome! thanks again. let me know if you need help testing or anything.

atEverychance commented 11 years ago

@gms-chris don't mean to press too hard, really appreciate any time you can dedicate to this, but any luck with this All Folders search fix? one of my clients keeps asking about it.

thanks again.

gms-chris commented 11 years ago

Sorry for the delay. I have a works-for-me implementation that is not as tested as I would like. We have had other work that has been more pressing and not really time to work on this. I might release a point-release just so that it should 'work more' for now. I have had to revert to a style that some other plugins use. It is ugly and you cannot perform any 'right-click' (open in new tab/window) style operations. This does seem to be the only way to work however, due to message ID conflicts between folders and the message ID being the only value that RC uses to identify a message in the message list. Not well tested are various operations:

atEverychance commented 11 years ago

yeah, will take a point release, that'd be great! thanks @gms-chris really appreciate it!

gms-chris commented 11 years ago

Initial fix pushed to master

adamjeelife commented 11 years ago

Thank you so much gms-chris

FireFoxIXI commented 10 years ago

Hello, we pushed a new version to stable that should solve this issues.

We tested:

Please give it a try and tell us if this works now as expected.

gms-chris commented 10 years ago

No response. Issues should all be addressed. Closing

cpdn commented 10 years ago

Hi. Same problem with browsing INBOX after search. Searching fine. Moving, deleting, etc. fine too. Click message in INBOX folder - "Could not load message from server" It's in INBOX folder only. Other folders -OK. Logout - login - INBOX folder work fine again.

advanced_search ver: 2.1.6 roundcube ver: 1.0.1