GMTrevis / Homeassistant-NodeRed-Systemair-VTR300

Sytemair VTR300 integration to Homeassistant using Node Red
40 stars 10 forks source link

Fireplace mode #8

Closed pittbull closed 2 years ago

pittbull commented 2 years ago

Hi again.

I have some issues activating the fireplace mode. This is what's recorded in the debug log when enabling the debug nodes related to "set main modes":

image

Any insight?

pittbull commented 2 years ago

It seems that the node "trykkvakt aktiv?" does not change to "fireplace mode" after having being activated a first time. I had to restart NR to get it working, but when the timer runs out on the first time and you try to reactivate it does not change. And the above mentioned node does not change.

GMTrevis commented 2 years ago

@pittbull you are correct, found a trykkleif/bug in the following node, this should fix the issue: image

image

pittbull commented 2 years ago

Wow. That is indeed a nice find :) Deeply buried.

Thanks. Confirming the fix works.

Ontrackx commented 2 years ago

The workspace contains some nodes that are not properly configured:

[VTR300 - Modbus] Ildsted - Format time (function) Are you sure you want to deploy?

i get this while changing?

GMTrevis commented 2 years ago

@Ontrackx: I saw that myself, i don't have a certain answer for that one but i think it might be related to node red releases/updates. The following solved it for my case: image

Ontrackx commented 2 years ago

Thanx tht fixed it, i know how to read code somewhat but not to find and correct it :)

Ontrackx commented 2 years ago

Screenshot_2022-10-24-20-09-13-62_c3a231c25ed346e59462e84656a70e50 This is spamming in logbook all the time, anyone know why?

GMTrevis commented 2 years ago

@Ontrackx a lot of code is made outside and in addition to the code running in the ventilation unit. When i made this logic there was so many loose threads to put to together including trail and error on the way to make it possible to control the ventilation unit the way i wanted.

So to your question: Each time a mode is changed are all the other modes turned off, this is checked each 10s (poll cycle) until the ventilation unit respond/the requested mode actually is set (actual feedback). The switch off service is limited to each 30s to reduce service calls. The switch off service calls generate script calls and since HA logs more or less everything, these operations will also be seen. In order to make the ventilation unit user interface with all this buttons (as i wanted), displaying the actual mode (not assumed) i didn't see any other way of solving the control in node red and HA, i also struggled with that the unit not always was setting the requested mode each time, so i had to frequently check the actual state until the new requested mode actually was set. Mixing control of different modbus registers for the different modes including a new mode (PPM Auto) also complicates stuff... The code has potential of being smarter, remembering the previous mode and using that could be an option to reduse the number of scripts beeing called at the same time. As for now i have to put this on hold as i dont have time for a while. please fill free to test and make suggested improvements, highly appreciated later when improving the code for controling the ventilation unit.