search

GMapeSplat / ComfyUI_ezXY

Collection of scripts, patches, and custom nodes for ComfyUI
GNU General Public License v3.0
24 stars 7 forks source link

OOM and Item form Dropdown errors #5

Open Botoni opened 6 months ago

Botoni commented 6 months ago

Hi,

I really like your nodes more than the efficiency ones, as I don't like everything encapsulated in meganodes.

The thing is that when plotting 3 or more SD1.5 checkpoints for 7 or more iterations I get OOM error, and when doing 2 or more SDXL the same. That doesn't happen with Efficiency's.

Also, I don't know why, but after I restarted ComfyUI the Item from Dropdown node stopped working and throwing an error when connecting to a Checkpoint Loader. I don't remember the error but it disappeared later the same day, so I can't reproduce it for now.

Lastly I observed that the iteration string from the ezXY Driver starts at 01 and the one from the Iteration Driver starts at 00, don't know if it's intended or not.

GMapeSplat commented 6 months ago

For the Dropdown bug, without an error log I can't help much. It has always been finicky. Adding or removing models then loading Comfy might break it like that.

For ezXY Driver, yeah that isn't intended. Both iteration outputs should be consistent. Thanks for reporting that one.

The OOM error is a pretty rough one. Looks like trying to load 3 checkpoints over 7 other rows/columns ends up loading the checkpoints once per iteration. So 21 checkpoints. I think efficiency nodes gets away with this by taking control of the checkpoint loader.

I might come back to this project eventually, but I don't have much time right now to work on it. So unfortunately I can't fix these problems. Thanks for showing interest.

Botoni commented 6 months ago

Ok, thank you for your work and making this public ;-)