search

GMaynard1 / emolt_project_management

Prioritizing new development directions and resolution of ongoing issues in the eMOLT project
GNU General Public License v3.0
1 stars 0 forks source link

qaqc_emolt flagging many "4" #120

Open jamespatrickmanning opened 1 year ago

jamespatrickmanning commented 1 year ago

noticed that flag=4 in about 25% of the emolt_QCed.csv data.

While emolt.dat has ~22K records, emolt_QCed.csv has only ~15K flag=0 records. There seems to be an excessive amounts being flagged as 4 when the difference in observed and NGDC depth is more than 20% of the observed depth.

In addition, when I looked at the latest version of qaqc_emolt.py on my machine, I noticed a few lines of code that suggest this flag=4 is only applied when the observed depth is >50 or <8m as follows:

if abs(df['depth'][k])>50 or abs(df['depth'][k])<8: 
    flag.append(4)
else:
    flag.append(0)

Where do I find the current version of the qaqc_emolt.py code in the ISOMEDIA machine?

xhx509 commented 1 year ago

Hi Jim

Here is the current 'qaqc_emolt.py' path on ISOMEDIA machine /var/www/vhosts/emolt.org/huanxin_ftp/weekly_project/qaqc_emolt.py The full code is like this below.

elif (abs(abs(df['depth'][k])-abs(depth_ngdc)))/df['depth'][k]>fraction_depth_error:

if abs(df['depth'][k])>50 or abs(df['depth'][k])<8:

flag.append(4)

else:

flag.append(0)

Huanxin

On Mon, Feb 27, 2023 at 2:10 PM Jim Manning @.***> wrote:

Assigned #120 https://github.com/GMaynard1/emolt_project_management/issues/120 to @xhx509 https://github.com/xhx509.

— Reply to this email directly, view it on GitHub https://github.com/GMaynard1/emolt_project_management/issues/120#event-8619337780, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAW6W6L43RFN4R7OCT4FRITWZT34FANCNFSM6AAAAAAVJZLCK4 . You are receiving this because you were assigned.Message ID: <GMaynard1/emolt_project_management/issue/120/issue_event/8619337780@ github.com>