search

GNOME-Nepal / website

Welcome to the official website of GNOME Nepal, crafted through the open-source contributions of our dedicated and talented developers.
https://nepal.gnome.org
MIT License
11 stars 20 forks source link

Add github workflow for formatting and linting checks on PRs and Lockfiles for reproducibility #73

Closed maskudo closed 5 days ago

maskudo commented 1 week ago

This PR aims to add a workflow to run formatting and linting checks on PR submit and improve project reproducibility by adding lockfiles for project dependencies.

Notes

  1. Package-lock.json has been removed from the gitignore file and checked into the repo. (This file is important for ensuring reproducibility of our project)
  2. Flake.nix and Flake.lock files have been added. We can use them to reproduce a developer environment with the appropriate version of nodejs and the act tool which can be used to run github workflows locally before pushing to production.
netlify[bot] commented 1 week ago

Deploy request for gnomenepal rejected.

Name Link
Latest commit 9363e0aeea429cb31c899d8b1fd361dd57e496de
utsavdotdev commented 1 week ago

Hi @maskudo ,

The linting and formatting are already handled using Git hooks introduced in PR #71. The website is optimized to support both recent and older versions of Node, so I don’t think reproduction is necessary. Regarding the package-lock.json, you can go ahead and include it.

utsavdotdev commented 5 days ago

Closed due to inactivity