search

GNS-Science / solvis-graphql-api

solvis-graphql-api
GNU Affero General Public License v3.0
1 stars 0 forks source link

49 typing on cached module #50

Closed DrCuriosity closed 5 months ago

DrCuriosity commented 5 months ago

In this PR:

Will need version bump, changelog, etc. for merge.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.30%. Comparing base (31dc029) to head (e58ae4a). Report is 35 commits behind head on main.

Files Patch % Lines
solvis_graphql_api/composite_solution/cached.py 66.66% 4 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #50 +/- ## =========================================== - Coverage 100.00% 92.30% -7.70% =========================================== Files 2 15 +13 Lines 32 832 +800 Branches 0 72 +72 =========================================== + Hits 32 768 +736 - Misses 0 51 +51 - Partials 0 13 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chrisbc commented 5 months ago

Thanks @DrCuriosity I see that GH/codecov integration has moved up a level and we're now getting notices for untested code additions - nice! We should start tidying these things up going forward but I'm happy for this to merge as-is.

actually that new codecov feature is messing with checks. I just wanna take a quick look at what's going on here.