Closed chrisbc closed 3 months ago
@chrisbc, just to be clear on where we're putting these functions: I'm guessing in InversionSolutionOperations
?
There are a couple of get_ruptures_...
functions there already, so it seems like a good fit.
I'm also wondering if it might be good to rename those existing functions to get_rupture_ids_...
so that they're more consistently and explicitly named? If I do that, I'll be passing the original method names through to the renamed methods with a DeprecationWarning
, so that things keep working but anyone depending on the old names can clean things up more easily.
This is part one of epic #30
done when:
cached.get_rupture_ids_for_location_radius function
cached.get_rupture_ids_for_fault_names
python enum
NB given that this filtering logic can be applied to any dataframe returning
rupture
information consider refactoring to make this more generalised (maybe a new ticket, but lets think about it now).