search

GNS3 / gns3-gui

GNS3 Graphical Network Simulator
http://www.gns3.com
GNU General Public License v3.0
2.17k stars 436 forks source link

Capture on link instead of port #1117

Closed julien-duponchelle closed 8 years ago

julien-duponchelle commented 8 years ago

Actually when you start a capture we ask for the interface where the capture should happen. But I'm not sure if it's usefull. Because in theory if GNS3 work the capture should be the same on both side.

My proposal is to remove the choice and behind the scene the network backend can decide where to capture, this mean the api for capture will be on /links in the controller instead of the network adapter.

The current implementation doesn't create issue but I imagine stuff like packet loss configuration will be on the link instead of the port. And in this case it seem logic to have all the packet manipulation in the link API.

julien-duponchelle commented 8 years ago

A note on a serial link the capture type should be asked it could be FRAME RELAY, PPP and HDLC

grossmj commented 8 years ago

I think I am fine with it excepting if someone see a specific usage I missed.

@ehlers, anyone?

ghost commented 8 years ago

I see only one use case for capturing on the port: Debugging if the link is working. But normally it's sufficient, looking at the interface counters.

So yes, I'm fine with that proposal as well.

julien-duponchelle commented 8 years ago

In theory all link should work in GNS3 you should not have to debug GNS3 internals. I think I we need it we can edit the code to force the capture on one side of the link.

grossmj commented 8 years ago

Ok, let's do it then.

julien-duponchelle commented 8 years ago

In the same time we need to process most of the capture controller side (write in the captures directory).