search

GNS3 / gns3-gui

GNS3 Graphical Network Simulator
http://www.gns3.com
GNU General Public License v3.0
2.12k stars 433 forks source link

GUI lockup when closing snapshot restore #2975

Open candlerb opened 4 years ago

candlerb commented 4 years ago

Describe the bug You can end up in a situation where:

GNS3 version and operating system (please complete the following information):

To Reproduce Steps to reproduce the behavior:

  1. Go to Edit > Manage Snapshots and restore from a snapshot.
  2. Go to Edit > Manage Snapshots again.
  3. Click Close button in bottom right-hand corner without restoring any snapshot (i.e. you just want to cancel the operation).
  4. From the menu select Edit > Manage Snapshots a third time.

Screenshots or videos At step 3, the snapshot window pops away then pops back completely blank:

image

It doesn't seem to be possible to remove it. But it's still possible to quit GNS3.

At step 4, all the menus remain greyed out:

image

At this point, you need to force-quit the application from Activity Monitor.

Additional context This has happened to me a few times in the past. I'm not sure if it's only when I close the snapshot window without restoring, but the above is a specific reproducible path.

grossmj commented 4 years ago

Unfortunately I cannot reproduce the problem.

candlerb commented 4 years ago

Odd. Maybe it's something about the specific snapshot we're restoring then. I'll send you a link to a gns3project separately.

candlerb commented 3 years ago

Just FYI, problem still exists in 2.2.14.

candlerb commented 3 years ago

This problem still exists with the new PyQt5 version in v2.2.24, although slightly different. The reproducer is the same:

  1. Go to Edit > Manage Snapshots and restore from a snapshot. This works fine.
  2. Go to Edit > Manage Snapshots again.
  3. Click Close button in bottom right-hand corner without restoring any snapshot (i.e. you just cancel the restore operation).

What happens (with macOS 10.14.6) is that the list of snapshots closes and then immediately re-opens:

image

It's populated, but clicking the "Close" button doesn't do anything.

Then if you go to Edit > Manage Snapshots a third time the GUI hangs. All the menus go grey, although it doesn't spin the CPU. Sending a "Quit" signal from Activity Monitor doesn't fix it, so it's necessary to send a "Force Quit".