search

GNS3 / gns3-gui

GNS3 Graphical Network Simulator
http://www.gns3.com
GNU General Public License v3.0
2.12k stars 433 forks source link

Double error messages with remote GNS3VM #3011

Open ghost opened 4 years ago

ghost commented 4 years ago

Describe the bug When I configure a remote server and use that as a GNS3VM each error is shown twice.

This does not happen with devices in the local server and in normal GNS3VMs.

GNS3 version and operating system (please complete the following information):

Normal local main server: local_main_server

Remote server, for demonstration I'm using a standard GNS3VM in VMware fusion as the remote server: remote_server

Remote VM as a GNS3VM: remote_gns3vm

To Reproduce Steps to reproduce the behavior:

  1. Configure remote server and remote GNS3VM as shown above
  2. Stop GNS3 and start again to have a stable environment
  3. Add a dynamips template in the GNS3VM
  4. Create a project and add the dynamips node running in the GNS3VM
  5. Start it
  6. Create an error, for example pkill dynamips in the GNS3VM
  7. The error message is shown twice

Screenshots or videos gui_screenshot

Additional context

I assume that happens, because for remote GNS3VMs two notification streams are created, one for the remote server and one for the GNS3VM.

/Users/behlers# grep notifications ~/.config/GNS3/2.2/gns3_server.log
2020-06-27 18:15:56 INFO compute.py:430 Connected to compute WebSocket 'http://172.20.1.1:3080/v2/compute/notifications/ws'
2020-06-27 18:15:56 INFO compute.py:430 Connected to compute WebSocket 'http://172.20.1.131:80/v2/compute/notifications/ws'
2020-06-27 18:16:06 INFO compute.py:430 Connected to compute WebSocket 'http://172.20.1.131:80/v2/compute/notifications/ws'
grossmj commented 4 years ago

Should be fixed now.

ghost commented 4 years ago

Should be fixed now.

Sad enough, it's not fixed.

I just downloaded the nighly build 2020-07-08 of v2.2 from SourceForge and re-tested. While #3010 is fixed (thanks for that), this issue is still present.

For me that's not surprising as this issue has nothing to do with the debug function, I haven't activated debuggung during this issue.

This does not happen with devices in the local server and in normal GNS3VMs.

This issue doesn't happen always, I noticed it only when I'm using a remote GNS3 VM.

grossmj commented 4 years ago

Sad enough, it's not fixed.

Must be because I haven't properly tested using a GNS3 VM. I will have a closer look then.

ghost commented 4 years ago

Please note, that normal GNS3 VMs (using a virtualization engine) don't have this issue. Only GNS3 VMs using a remote VM are affected.

grossmj commented 4 years ago

I assume that happens, because for remote GNS3VMs two notification streams are created, one for the remote server and one for the GNS3VM.

Correct, I could reproduce the problem. This will need some careful refactoring since we could easily break something here.

2020-07-09 20:13:38 INFO compute.py:430 Connected to compute 'ff035757-1d5b-4451-a01d-c29c11701068' WebSocket 'http://172.16.9.128:80/v2/compute/notifications/ws'
2020-07-09 20:13:38 INFO compute.py:430 Connected to compute 'vm' WebSocket 'http://172.16.9.128:80/v2/compute/notifications/ws'
ghost commented 4 years ago

This will need some careful refactoring since we could easily break something here.

Perhaps the milestone could be shifted to 2.3 or even later. For me this is more of a nuisance than a serious problem

grossmj commented 4 years ago

Perhaps the milestone could be shifted to 2.3 or even later. For me this is more of a nuisance than a serious problem

Agreed, we are in the process to work on a new back-end and this could be solved at that time.