search

GNS3 / gns3-registry

GNS3 devices registry
GNU General Public License v3.0
326 stars 389 forks source link

Add appliance_id #617

Closed grossmj closed 2 years ago

grossmj commented 2 years ago

Each appliance will have a fixed ID. This will help to have implement image version agnostic projects. See https://github.com/GNS3/gns3-server/discussions/1960

b-ehlers commented 2 years ago

Now check.py will fail for all appliance with a registry_version < 6. That are almost all.

grossmj commented 2 years ago

Thanks, looks like I should allow additional properties in JSON schemas. Additional properties are allowed in the GNS3 GUI: https://github.com/GNS3/gns3-gui/blob/2.2/gns3/schemas/appliance.json

grossmj commented 2 years ago

Fixed: https://github.com/GNS3/gns3-registry/commit/d183a8790a5a0b9fbd2d3bb122d1e4a04cf92ed8

b-ehlers commented 2 years ago

Fixed: d183a87

Not here. check.py show me, that juniper-vmx-vcp.gns3a uses multiple images with the same MD5 and several appliances are falsely detected as downgradable to a lower registry version.

grossmj commented 2 years ago

Not here. check.py show me, that juniper-vmx-vcp.gns3a uses multiple images with the same MD5 and several appliances are falsely detected as downgradable to a lower registry version.

Argh, ok I will have a closer look. Apart from check.py, do you see any unforeseen consequences of this merge for existing GNS3 clients?

b-ehlers commented 2 years ago

No, the GNS3 GUI and server shouldn't care about additional properties. It's just check.py, that is more strict to generate warnings.