Closed b-ehlers closed 1 year ago
I checked with them. They are going to add full sync for Q4 2022.
Thanks, that are good news.
@grossmj Is this still planned and on schedule?
@grossmj Is this still planned and on schedule?
Let me ask them again.
Much better now, https://gns3.com/marketplace/appliances shows even more appliances than here.
The following appliances are shown twice:
FortiADC KEMP Free VLM OpenBSD OpenWrt Realview WatchGuard Windows
The appliances are partly named slightly different in the Marketplace. For example cisco-wsav.gns3a is named here "Web Security Virtual Appliance" while the marketplaces names it "Cisco Web Security Virtual Appliance". Both names are fine, but this makes it impossible to automatically compare these two lists. So I can't tell if something is missing or included twice.
That reminds me, I need to update the FortiADC appliance on the registry.
On Fri, Jan 13, 2023 at 08:48 B. Ehlers @.***> wrote:
Much better now, https://gns3.com/marketplace/appliances shows even more appliances than here.
The following appliances are shown twice:
FortiADC KEMP Free VLM OpenBSD OpenWrt Realview WatchGuard Windows
The appliances are partly named slightly different in the Marketplace. For example cisco-wsav.gns3a is named here "Web Security Virtual Appliance" while the marketplaces names it "Cisco Web Security Virtual Appliance". Both names are fine, but this makes it impossible to automatically compare these two lists. So I can't tell if something is missing or included twice.
— Reply to this email directly, view it on GitHub https://github.com/GNS3/gns3-registry/issues/688#issuecomment-1381876147, or unsubscribe https://github.com/notifications/unsubscribe-auth/APZX5I6GYD2XHH7JJ5PXBATWSFMJJANCNFSM6AAAAAAQMM25IY . You are receiving this because you commented.Message ID: @.***>
-- Ean L. Towne
@.***
@b-ehlers thanks I will report this to the team 👍
I had a deeper look into the differences between the marketplace and this registry. Here my detailed report:
Marketplace Name | Issue |
---|---|
EXOS | Old marketplace appliance, replaced by "EXOS VM" appliance |
FortiADC | Marketplace has one appliance referencing to the registry (good) and another one referencing to https://raw.githubusercontent.com/adosztal/gns3-registry/master/appliances/fortiadc.gns3a |
KEMP Free VLM | Marketplace references one appliance to github.com/GNS3 (correct with uppercase GNS3) and another one to github.com/gns3 (lowercase) |
LEDE | Deleted from registry, still in marketplace |
OpenBSD | Marketplace references one appliance to https://raw.githubusercontent.com/GNS3/gns3-registry/master/appliances/openbsd.gns3a (good) and another one to https://github.com/GNS3/gns3-registry/blob/master/appliances/openbsd.gns3a (old style) |
OpenWrt Realview | Same issue as with OpenBSD |
Riverbed SteelHead | riverbed-steelhead-cx.gns3a deleted from registry, still in marketplace |
WatchGuard | Registry issue: same name in two appliances (watchguard-fireboxv.gns3a and watchguard-xtmv.gns3a) |
Windows | Registry issue: same name in two appliances (windows.gns3a and windows-xp+ie.gns3a) |
So the issues with the double entries for WatchGuard and Windows are an issue within this registry and need to be fixed here. The other issues should be solved in the Marketplace.
Update: The following list shows appliances with different names in the marketplace and the registry. If someone wants a boring job, he/she can adjust them.
Appliance | Marketplace Name | Registry Name |
---|---|---|
asterisk.gns3a | AsteriskNOW | AsteriskNOW / FreePBX |
brocade-vadx.gns3a | Brocade vADX | Brocade Virtual ADX |
brocade-vrouter.gns3a | Brocade vRouter | vRouter |
brocade-vtm.gns3a | Brocade vTM DE | vTM DE |
cisco-nxosv9k.gns3a | NX-OSv 9000 | Cisco NX-OSv 9000 |
cisco-wsav.gns3a | Cisco Web Security Virtual Appliance | Web Security Virtual Appliance |
citrix-netscaler-vpx.gns3a | Citrix NetScaler VPX | NetScaler VPX |
cloudrouter.gns3a | Cloudrouter | CloudRouter |
dell-ftos.gns3a | Dell FTOS | Dell OS9 |
f5-bigip.gns3a | F5 BIG-IP | F5 BIG-IP LTM VE |
forticache.gns3a | Forticache | FortiCache |
frr.gns3a | FRRouting | FRR |
hp-vsr1001.gns3a | HP VSR1001 | HPE VSR1001 |
juniper-vsrx.gns3a | Juniper vSRX | vSRX |
mikrotik-chr.gns3a | MikroTik Cloud Hosted Router | MikroTik CHR |
net_toolbox.gns3a | Networkers' Toolkit | Toolbox |
opensuse.gns3a | OpenSUSE | openSUSE |
openvswitch-management.gns3a | Open vSwitch with management interface | Open vSwitch management |
parrot-os.gns3a | Parrot OS | ParrotOS |
proxmox-mg.gns3a | Proxmox Mail Gateway | Proxmox MG |
smoothwall.gns3a | Smoothwall | Smoothwall Express |
sophos-xg.gns3a | Sophos XG | Sophos XG Firewall |
trendmicro-iwsva.gns3a | InterScan Web Security Virtual Appliance | IWS VA |
ubuntu-server.gns3a | Ubuntu server (custom) | Ubuntu Server |
viptela-edge-genericx86-64.gns3a | VIPtela Edge | vEdgeCloud |
viptela-smart-genericx86-64.gns3a | VIPtela Smart | vSmart |
viptela-vmanage-genericx86-64.gns3a | VIPtela vManage | vManage |
windows_server.gns3a | Windows server | Windows Server |
So, here is a question. What is the source of truth? Is this GitHub repository the root or is the Marketplace?
Should there be a tag or some form of differentiation to to show "official" appliances from the registry vs. appliances added directly to the Marketplace?
Should the ability to add directly to the Marketplace be removed, except as sync's with this repo?
So, here is a question. What is the source of truth? Is this GitHub repository the root or is the Marketplace?
The source of truth should be the GitHub repository.
Should the ability to add directly to the Marketplace be removed, except as sync's with this repo?
Indeed, we should remove that ability 👍
@b-ehlers thanks a lot for your help. I have deleted the old appliances from the marketplace and rename the WatchGuard and Windows ones.
@stevenyuen
I think you should use the appliance_id
field to uniquely identify an appliance. The IDs are unique and won't change.
Also, you should handle both appliance deletions and updates (including name changes). That would take care of the different names in the marketplace and the registry as reported above.
One question, we could add a vendor_logo
field in the .gns3a files that would point to a logo than can be used in the marketplace. Do you think it is a good idea? if yes, where should these logos be stored?
@grossmj agreed about using the appliance_id
. We've added a metadata field appliance_id
for all current and new gns3.com marketplace appliances which should now match the appliance_id
specified in the registry .gns3a
files. This has been deployed and re-synced.
There is also now a webhook endpoint in place that's ready to ingest push events from this repository. Updates to appliances on gns3.com will be matched using the appliance_id
field. I'll DM you the endpoint so you can configure the repository's webhook settings.
I have just checked again, the registry and the marketplace contain the same appliances with the same names. As far as I am concerned everything is fine and the issue can be closed.
@b-ehlers thanks for the confirmation!
@asabhaney perfect, thanks a lot 👍 Also, should the ability to add an appliance directly on the marketplace be removed?
Currently this repository contains 183 appliances, the GNS3 community site https://gns3.com/marketplace/appliances shows only 138 appliances. Therefore 45 appliances are not shown and won't get any attention.
Please ask the manager of gns3.com to update its website to show all appliances.