search

GNS3 / gns3-server

GNS3 server
GNU General Public License v3.0
768 stars 258 forks source link

Update telnet_server.py #2339

Closed spikefishjohn closed 5 months ago

spikefishjohn commented 5 months ago

Set tcp keepalive timers to 60 seconds. Seems to default to 2 hours on ubuntu 22. Most firewalls will age out an idle tcp session at 1 hour.

Will not address telnet console failing after a tcp session has failed (TimeoutError).

elico commented 5 months ago

@grossmj With the changes since v2.2.45 I cannot connect via telnet to any console.

grossmj commented 5 months ago

I noticed the tests also failed. I will have a closer look soon.

Thanks.

spikefishjohn commented 5 months ago

Oh the shame.

I used the wrong object name in patch-2. I already submitted patch-3 to use the correct sock object.

https://github.com/GNS3/gns3-server/pull/2340

grossmj commented 5 months ago

No worries, I have merged your PR ;)