GNS3 / gns3-web-ui

WebUI implementation for GNS3
GNU General Public License v3.0
149 stars 52 forks source link

An in-range update of angular2-hotkeys is breaking the build 🚨 #194

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 6 years ago

The dependency angular2-hotkeys was updated from 2.1.3 to 2.1.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

angular2-hotkeys is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - βœ… **ci/circleci: build:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/GNS3/gns3-web-ui/741?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - βœ… **continuous-integration/travis-ci/push:** The Travis CI build passed ([Details](https://travis-ci.org/GNS3/gns3-web-ui/builds/452621443?utm_source=github_status&utm_medium=notification)). - ❌ **continuous-integration/appveyor/branch:** AppVeyor build failed ([Details](https://ci.appveyor.com/project/gns3-build/gns3-web-ui/builds/20160560)).

Commits

The new version differs by 3 commits.

  • f6357fc 2.1.4
  • cd0afc6 Updated @angular/core peerDependency to include Angular7. Adjusted readme to reflect this as well.
  • ef738b1 Version bump to 2.1.3 and fixed prepublish command to prevent broken releases.

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 6 years ago

After pinning to 2.1.3 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

ziajka commented 5 years ago

Fixed by: https://github.com/GNS3/gns3-web-ui/commit/27946c6a8eb28ad59f4a2ece284c9eb328966fc2