Compiler warnings in iniparser.c

[ghost]

Three warnings in src/iniparser/iniparser.c are shown when building ubridge, here a full log: https://ci.appveyor.com/project/gns3-build/ubridge/builds/32494335

cc -O3 -Wall -IWpdPack\Include   -c -o src/iniparser/iniparser.o src/iniparser/iniparser.c
In file included from src/iniparser/iniparser.c:10:
src/iniparser/iniparser.c: In function ‘iniparser_load’:
src/iniparser/iniparser.c:766:52: warning: array subscript has type ‘char’ [-Wchar-subscripts]
  766 |                 ((line[len]=='\n') || (isspace(line[len])))) {
      |                                                ~~~~^~~~~
src/iniparser/iniparser.c:791:32: warning: ‘sprintf’ may write a terminating nul past the end of the destination [-Wformat-overflow=]
  791 |             sprintf(tmp, "%s:%s", section, key);
      |                                ^
src/iniparser/iniparser.c:791:13: note: ‘sprintf’ output between 2 and 2050 bytes into a destination of size 2049
  791 |             sprintf(tmp, "%s:%s", section, key);
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[grossmj]

I do not see the warnings when compiling with GCC 7.5.0 on Linux.

There is an issue opened upstream regarding this: https://github.com/ndevilla/iniparser/issues/124

The fix is most likely to use snprintf()

[ghost]

I see these warning with gcc 8.3.0 from Debian Buster. That's also the version shipped with Ubuntu 19.04.