GNSPS / solidity-bytes-utils

Utility Solidity library composed of basic operations for tightly packed bytes arrays
The Unlicense
514 stars 109 forks source link

Support uint8, uint16, uint32 #19

Closed hihiben closed 5 years ago

hihiben commented 5 years ago

Support the serialization of several lengths of unsigned integer.

GNSPS commented 5 years ago

First of all thank you so much for contributing @hihiben! 😄 🙌

I'll make some notes in the PR and help you sort things out!

GNSPS commented 5 years ago

I just realized my huge stupidity! 😂 Sorry for requesting changes in perfectly good code @hihiben! 🙇

I'll revert my latest commit and keep the Assert.equal() one which is still useful. We can typecast it to uint256 and get the error messages.

hihiben commented 5 years ago

Thanks a lot for this great work! Glad that I can help.