aspell-helper
commented
19 years ago Jose Da Silva josedasilva\@sf commented on 2005-05-18 03:00:48 UTC
Logged In: YES user_id=1138138
x.c is a mini test routine to try out the various conditions without having to completely recompile aspell, for example: str1 < -2billion, str1 > +2billion, str1 == "\t\r +";
to compile: gcc -o x x.c
NOTE: I noticed that: long strtoi_c(const char * npter, char ** endptr) { appears to agree better with the compiler versus: long strtoi_c(const char * npter, const char ** endptr) {
Jose Da Silva josedasilva\@sf created a patch on 2005-05-18 02:40:09 UTC (Orig. from https://sourceforge.net/p/aspell/patches/108)
These modifications should allow strtoi_c() to correctly
return a long value between -2billion and +2billion.
The current routine ignores overflow and will return an
incorrect value if a very large number is present, for
example: 12345678901234567890.
The current routine will not return a correct negative value as written right now.
Another problem is that there may not be a number present, but the current routine modifies endptr if
ascii spaces are found or if a sign -/+ value without a
number.
With the new suggestions, now endptr will only point to
correct endptr if a number is found, otherwise endptr points
remains at beginning of str.
This allows user to perform a test for errors:
value = strtoi_c(x, &y);
if (x == y) then error;
...or to retry test using a more powerful routine:
value = strtoi_c(x, &y);
if (x == y) then extralongvalue = strtoextralongi_c(x, &y);
The attached diff file is based on latest strtonum.cpp in
CVS (may17,2005)
--------suggested updated routine (below)-------
long strtoi_c(const char * npter, const char ** endptr) {
char * str = (char*)npter;
long num = 0;
char sign = 0;
*endptr = str;
while (asc_isspace(*str)) {
str++;
}
if (*str == '-' || *str == '+') {
sign = *(str++) == '-' ? -1 : 0;
}
while (*str >= '0' && *str <= '9') {
num = num * 10 + (long)(*str - '0');
if (num < 0) {
*endptr = (char*)npter;
return -1;
}
*endptr = ++str;
}
if (sign) num = -num;
return num;
}