search

GNUAspell / aspell

http://aspell.net
GNU Lesser General Public License v2.1
243 stars 53 forks source link

modules/speller/default/vector_hash-t.hpp: fix gcc-15 build #650

Closed trofi closed 4 months ago

trofi commented 4 months ago

Upcoming gcc-15 added extra checks for template instatiation that is guaranteed to fail in https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=313afcfdabeab3e6705ac0bd1273627075be0023

As a result aspell build now fails as:

In file included from modules/speller/default/readonly_ws.cpp:51:
modules/speller/default/vector_hash-t.hpp: In member function 'void aspeller::VectorHashTable<Parms>::recalc_size()':
modules/speller/default/vector_hash-t.hpp:186:43: error: 'class aspeller::VectorHashTable<Parms>' has no member named 'e'
  186 |     for (iterator i = begin(); i != this->e; ++i, ++this->_size);
      |                                           ^
modules/speller/default/vector_hash-t.hpp:186:59: error: 'class aspeller::VectorHashTable<Parms>' has no member named '_size'; did you mean 'size'?
  186 |     for (iterator i = begin(); i != this->e; ++i, ++this->_size);
      |                                                           ^~~~~
      |                                                           size

It looks like _size is size_ mis-spelling and e was not introduced here.

trofi commented 4 months ago

Alternatively we can delete the function completely as it's not callable without a build error today. WDYT?