GO-Eratosthenes / dhdt

Extracting topography from mountain glaciers, through the use of shadow casted by surrounding mountains.
https://dhdt.readthedocs.io
Apache License 2.0
7 stars 1 forks source link

Avoiding bare `except` in `radon_orientation` #101

Closed fnattino closed 1 year ago

fnattino commented 1 year ago

Bare 'except' should be avoided according to PEP8 (they are too generic). What kind of error is targeted here (ValueError? IndexError?)? If the bare except cannot be avoided, we can mark this line as an exception to PEP8 in the following way:

except :  # noqa: E722

In dhdt/processing/geometric_image_describtion.py, function radon_orientation:

https://github.com/GO-Eratosthenes/dhdt/blob/bec72db5a94c254b7aff4a3f45f357867f53cabb/dhdt/processing/geometric_image_describtion.py#L93