GO-Eratosthenes / dhdt

Extracting topography from mountain glaciers, through the use of shadow casted by surrounding mountains.
https://dhdt.readthedocs.io
Apache License 2.0
7 stars 1 forks source link

failing tests for matching tools #111

Closed fnattino closed 9 months ago

fnattino commented 1 year ago

This works if C is 2-dimensional, but gives an error otherwise (see e.g. this test, which fails since C is 3D and thus ij has 3 elements). Maybe this was meant to be ij[:-1] (drop last element, instead of invert the tuple)? Also to check carefully the need of using 'F' ordering in the previous line, since this basically switches the order of the 'i' and 'j' indices..

https://github.com/GO-Eratosthenes/dhdt/blob/8b8af330e3ec93212265d2be80fdee30d7d4fd5f/dhdt/processing/matching_tools.py#L76