search

GOATS2K / overpass

A self-hosted live video streaming platform with Discord authentication, auto-recording and more!
MIT License
347 stars 15 forks source link

Update discord avatar on login #42

Closed natehalsey closed 2 years ago

natehalsey commented 2 years ago

I haven't Author/DevQA'd this.

GOATS2K commented 2 years ago

There's absolutely no need to introduce Pydantic here. That'll come with the new FastAPI migration, so I suggest that you just replace the avatar url in the database if it's different than the one that already exists with an UPDATE statement.

natehalsey commented 2 years ago

There's absolutely no need to introduce Pydantic here. That'll come with the new FastAPI migration, so I suggest that you just replace the avatar url in the database if it's different than the one that already exists with an UPDATE statement.

Pydantic has a lot of nice features and goes along well with typing. I can remove it here, but I do recommend it's use. It doesn't have to be based on your overarching goal of FastAPI migration.

GOATS2K commented 2 years ago

I'm well aware of that, but it's not needed here, and there's no need to introduce a new dependency for such a trivial bug like this.