search

GOCDB / gocdb-failover-scripts

Scripts and doc for hosting a failover
1 stars 2 forks source link

Add MariaDB dumpfile fetch and import. #11

Closed ghost closed 2 years ago

ghost commented 3 years ago

Draft request at this stage as preview hoping for comments, on style and substance, and expecting more integration work to be needed.

Closes #7 #5 (for MariaDB only)

But does not yet address #6

gregcorbett commented 3 years ago

Is dbImport.pwd intended to be used for the configuration of other mysql options? or solely for the password?

It's referenced as mysqlOptionsPath in the code, but the templates name suggests its only for the password.

gregcorbett commented 3 years ago

codacy has highlighted somethings as well (though the README issues probably keep the file self consistent, so if you wanted to fix them, please do it in a standalone PR.

ghost commented 3 years ago

Is dbImport.pwd intended to be used for the configuration of other mysql options? or solely for the password?

It's referenced as mysqlOptionsPath in the code, but the templates name suggests its only for the password.

Yes, that's a bit confusing. There's no intent, but it is possible and there seems no reason to restrict it. I have renamed to a .cnf_template suffix and included the user so that all mysql options arrive through that route. And expanded the comments in config.ini.

ghost commented 3 years ago

After discussion:

  1. Add ISO 8601 timestamp to the logged output
  2. Implement failure retry with delay backoff
ghost commented 2 years ago

Closing for now as I'll be force pushing some intermediate/incomplete/untested updates.