Refactor scripts for ease of unittesting the db dump recent script

GOCDB / gocdb-failover-scripts

Scripts and doc for hosting a failover

1 stars 2 forks source link

Refactor scripts for ease of unittesting the db dump recent script #22

Closed gregcorbett closed 1 year ago

gregcorbett commented 1 year ago

~~Depends on #23~~

Ensures all timestamps are treated as UTC
Moves existing functionality of check_db_dump_recent.py into a class for ease of unit testings
Updates the README.md

Sae126V commented 1 year ago

It seems there is an empty file: check/init.py. Is it intentional ?

Sae126V commented 1 year ago

I finished my review. LGTM

gregcorbett commented 1 year ago

It seems there is an empty file: check/init.py. Is it intentional ?

Yes, it is used to mark a directory as a Python package so that unit tests will be able to import it.

gregcorbett commented 1 year ago

I have rebased on top of the latest main (which has removed the whitespace commit already applied in #21) and squashed the SPG fixes into one commit.