search

GOCDB / gocdb

Grid Operations Configuration Management Database. A Repository, Portal and REST style API for managing Grid and Cloud topology objects including; projects, administrative domains, sites, services, service-endpoints, service-groups, downtimes, users, roles and business rules.
Apache License 2.0
12 stars 27 forks source link

[GT-141]-pre-select site, services and endpoints #439

Closed Sae126V closed 1 year ago

Sae126V commented 1 year ago

Case 1: If the user goes to the sites and tries to add recent downtimes. Then the user should be able to see the site, the services, and the endpoints pre-selected. Case 2: If the user goes to the services and tries to add recent downtimes. Then the user should see the specific service-related endpoints that are pre-selected.

"Resolves #229"

gregcorbett commented 1 year ago

If you add "Resolves #229" to the PR description, GitHub should automatically link this PR to the GitHub issue.

gregcorbett commented 1 year ago

I've marked some of the issues codeclimate has found as "Confirmed". These look like they are mostly stylist things. Could these, and only these be addressed? The other things codeclimate has found are beyond the scope of this PR.

We try and ensure all new GOCDB code follows the PSR-12 standard.

Sae126V commented 1 year ago

I have just made an update that fixes the code climate issues. If anyone wants to look, feel free to use the VM itself.

VM: 172.16.105.133 with root.

gregcorbett commented 1 year ago

If you add "Resolves #229" to the PR description, GitHub should automatically link this PR to the GitHub issue.

Can you add this?

When trying to test case 2, the Service box did not appear so I was unable to submit a downtime. Does that happen for you @Sae126V?

image

gregcorbett commented 1 year ago

Codeclimate has also identified some more low hanging fruit for issues to fix - I've marked them as "CONFIRMED".

gregcorbett commented 1 year ago

Looks good, I've added some comments / suggestions.

Sae126V commented 1 year ago

I have updated my comments for better readability and addressed the issues . The rest of the comments need a team inputs. We can discuss it at the dev meeting.

gregcorbett commented 1 year ago

There's an odd side effect of this change when clicking "Add Downtime" from the left hand menu. Going to /portal/index.php?Page_Type=Add_Downtime page shouldn't pre select a site, but it does.

image

Also, as an GOCDB Admin - I should see every site within GOCDB in the "Select Affected Site" list (as per GOCDB 5.10.4 behaviour), but when running this change, I only see sites that I have a Role over in that list.

Could you look into both those things @Sae126V ?

Sae126V commented 1 year ago

Raised another PR with CLEAN code.