search

GOCDB / gocdb

Grid Operations Configuration Management Database. A Repository, Portal and REST style API for managing Grid and Cloud topology objects including; projects, administrative domains, sites, services, service-endpoints, service-groups, downtimes, users, roles and business rules.
Apache License 2.0
12 stars 27 forks source link

Use the beta channel phpcodesniffer #443

Closed gregcorbett closed 1 year ago

gregcorbett commented 1 year ago

Needed to enforce PSR12, see: https://docs.codeclimate.com/docs/phpcodesniffer#standard

rowan04 commented 1 year ago

14841 issues to fix?!

gregcorbett commented 1 year ago

14841 issues to fix?!

Haha yep, I hoping that means codeclimate is now picking up PSR12 style issues, and it's treating them as new issues because these issues aren't currently detected on dev. But I can't confirm that because there are too many issues for codeclimate to render (which is why I had some test PRs: #441 and #442).

Another hope is that PRs checked after this one has been merged will be compared to this new 14841 baseline - and as such the change will be useful.

If merging this PR means that all future PRs codeclimate just says "too many issues", then this change is not useful and I shall revert.