[GT-172] Add blank line across the codebase for PHP files

GOCDB / gocdb

Grid Operations Configuration Management Database. A Repository, Portal and REST style API for managing Grid and Cloud topology objects including; projects, administrative domains, sites, services, service-endpoints, service-groups, downtimes, users, roles and business rules.

Apache License 2.0

12 stars 28 forks source link

[GT-172] Add blank line across the codebase for PHP files #457

Closed Sae126V closed 1 year ago

Sae126V commented 1 year ago

Adding a single empty Line across the codebase at the EOF. There won't be any impact in-terms of functionality or behaviour. This change applies ONLY to the codebase.

"Please feel free to give any thoughts or comments on this" ---

"Resolves GT-172"

gregcorbett commented 1 year ago

Can you rebase this ontop of the latest dev? That should remove the strange character change, as that has been merged in (see #471) separately.

gregcorbett commented 1 year ago

Looks like you'll need to update your local copy of the upstream dev branch and rebase again - there's still conflicts.

gregcorbett commented 1 year ago

I've documented the fix to the weirdness here: https://stfc.atlassian.net/wiki/spaces/GTT/pages/160170035/GOCDB+Developement#Troubleshooting, as this isn't the first time we have seen it (https://github.com/GOCDB/gocdb/pull/447#issuecomment-1534370073).

Sae126V commented 1 year ago

Rebased and verified.