[GT-181] Add last Logged In field in users details

GOCDB / gocdb

Grid Operations Configuration Management Database. A Repository, Portal and REST style API for managing Grid and Cloud topology objects including; projects, administrative domains, sites, services, service-endpoints, service-groups, downtimes, users, roles and business rules.

Apache License 2.0

12 stars 28 forks source link

[GT-181] Add last Logged In field in users details #458

Open Sae126V opened 1 year ago

Sae126V commented 1 year ago

To help with user support when someone queries one of the account deletion emails, it would be useful to be able to see when the account was last logged in to in the web interface.

As part of this ticket, I have used the name like site_table_row_even and site_table_row_odd for the Last Logged In field instead of site_table_row_1 and site_table_row_2.

"Resolves #456 ".

gregcorbett commented 1 year ago

Looks good, I've left two comments/questions.

gregcorbett commented 1 year ago

I spotted a couple of odd things:

The width of the "User Details" table on Page_Type=User changes based on whether "Last Logged In" is displayed or not. I presume this is because this line changes from being 1st to 2nd in the table. Can you move the "Last Logged In" the bottom of the "User Details" table?
The decorator string when a user goes to revoke another user's role is wrong - I get "Self revoke own role"

As part of this ticket, I have used the name like site_table_row_even and site_table_row_odd for the Last Logged In field instead of site_table_row_1 and site_table_row_2.

Please put this into it's own PR.

Can you also split out the broader line length and refactoring into seperate PRs as well?

gregcorbett commented 1 year ago

with #477 being merged, is the PR still needed?

Sae126V commented 1 year ago

with #477 being merged, is the PR still needed?

Regarding the functionality wise. We can close this, Greg. I will create another PR for site_table_row_even and site_table_row_odd change if we need. Does that make sense ?

tofu-rocketry commented 7 months ago

with #477 being merged, is the PR still needed?

Regarding the functionality wise. We can close this, Greg. I will create another PR for site_table_row_even and site_table_row_odd change if we need. Does that make sense ?

Can this be closed then? You can stick a speculative Issue in for the row changes even if you're not sure (there's a "question" tag for a reason), but it's better to tidy up unneeded PRs