search

GOCDB / gocdb

Grid Operations Configuration Management Database. A Repository, Portal and REST style API for managing Grid and Cloud topology objects including; projects, administrative domains, sites, services, service-endpoints, service-groups, downtimes, users, roles and business rules.
Apache License 2.0
12 stars 27 forks source link

Add a check on line length to PHP Codesniffer #468

Closed gregcorbett closed 10 months ago

gregcorbett commented 10 months ago

According to PSR-12, lines SHOULD NOT be longer than 80 characters, so I think it would be good to flag if lines go over 80 so we can see if they can easily be broken down.

gregcorbett commented 10 months ago

According to PSR-12, lines SHOULD NOT be longer than 80 characters, so I think it would be good to flag if lines go over 80 so we can see if they can easily be broken down.

80 also works well on smaller laptop screens, enabling a split diff to be disaplayed in GitHub without wrapping.

Sae126V commented 10 months ago

LGTM; I believe we are ONLY warning the users about line limit and NOT throwing any errors or others.