search

GOCDB / gocdb

Grid Operations Configuration Management Database. A Repository, Portal and REST style API for managing Grid and Cloud topology objects including; projects, administrative domains, sites, services, service-endpoints, service-groups, downtimes, users, roles and business rules.
Apache License 2.0
12 stars 28 forks source link

[GT-187] Add support for selecting mutiple sites #472

Open Sae126V opened 1 year ago

Sae126V commented 1 year ago

Resolves: https://github.com/GOCDB/gocdb/issues/261

Partially address: https://github.com/GOCDB/gocdb/issues/85 and https://github.com/GOCDB/gocdb/issues/66 .

Addressed @gregcorbett comments:

### Suggestion 1: Include the Site Name next to the downtime link on creation, i.e.:

New Downtimes successfully created. Please click the links below for more information.

### Suggestion 1: Only display the start and end time once on the "Confirm Downtime" page, i.e.:

Severity: WARNING Description: foo bar Starting (UTC): 08/09/2023 00:00 Ending (UTC): 18/09/2023 00:00 Site Name: Brunnen GS ... Site Name: Torch ...

gregcorbett commented 1 year ago

Has #475 superseded this PR?

Sae126V commented 1 year ago

Has #475 superseded this PR?

This PR is Having Mix and match of addressing PSR-12 issues mostly, it includes function level refractor(Minor improvements) etc. It is in draft as of now. Until I take a pull from dev to clear blockers for this.

tofu-rocketry commented 7 months ago

Has #475 superseded this PR?

This PR is Having Mix and match of addressing PSR-12 issues mostly, it includes function level refractor(Minor improvements) etc. It is in draft as of now. Until I take a pull from dev to clear blockers for this.

If that's the case, can you then update the title and description, and make it clear what PR it's waiting on to be merged first?