Improvements to API Credential Management - Githubissues

GOCDB / gocdb

Grid Operations Configuration Management Database. A Repository, Portal and REST style API for managing Grid and Cloud topology objects including; projects, administrative domains, sites, services, service-endpoints, service-groups, downtimes, users, roles and business rules.

Apache License 2.0

12 stars 28 forks source link

Improvements to API Credential Management #480

Open gregcorbett opened 1 year ago

gregcorbett commented 1 year ago

While reviewing #464, I noticed some pre-exisiting things that could be improved.

[ ] Output when processing and doing nothing to an API Credential, similiar to inactive user removal, see: https://github.com/GOCDB/gocdb/blob/5.10.4/resources/RemoveInactiveUsersRunner.php#L43 and https://github.com/GOCDB/gocdb/blob/5.10.4/resources/RemoveInactiveUsersRunner.php#L78
[ ] When doing a dry run, last used time is reported: https://github.com/GOCDB/gocdb/blob/dev/resources/ManageAPICredentials/ManageAPICredentialsActions.php#L258. This could be NULL and that case is not handled, causing the dry run to fail.