Open gregcorbett opened 2 months ago
Some of those changes have been captured here: gregcorbett@18349e2.
It would be good to capture if we need to add doctrine/annotations
, as the documentation seems to suggest only symfony/cache
is needed.
Some of those changes have been captured here: gregcorbett@18349e2.
It would be good to capture if we need to add
doctrine/annotations
, as the documentation seems to suggest onlysymfony/cache
is needed.
Ah it looks like it will be needed eventually: https://github.com/GOCDB/gocdb/pull/344#discussion_r869305680, but maybe only for Doctrine 2.11+.
6.5
7.5
8.5
9.6
5.6 was omitted from that list because it supported PHP 5.X, so it doesn't feel like a sensible point to rest at - might as well just go straight through to 6.5.
Upgrading to ORM 2.10 requires changes to the codebase. Some of those changes have been captured here: https://github.com/gregcorbett/gocdb/commit/18349e22b12309008dc0a91808bdf90d1b3eb8c4.
However, they are not sufficient to get the unit tests to run successfully, with all the test throwing the error:
This would seem to be caused by our version of PHPUnit. Upgrading is not trivial, as simple bumping the PHPUnit version results in different errors.
PHPUnit 9.6 is the last version to support PHP7, so using that version would be ideal. But not knowing the scale of this issue, I would suggest we step through the following PHPUnit versions, which should all work under PHP7.4, and potentially make PRs for each if the changes start to become too numerous.