Feature: Add percentage difference

GODrums / BetterFloat

Enhance your website experience on CSFloat, Skinport & Skinbid

https://betterfloat.com/

Other

39 stars 10 forks source link

Feature: Add percentage difference #20

Closed dduart3 closed 1 year ago

dduart3 commented 1 year ago

Since this wasn't a big deal I decided to fork the project and create a branch with a solution for this in which I did the following:

Renamed the Injectionhandler.ts file located in the src/ route to injectionhandler.ts because it was causing errors at the time of the webpack compilation not allowing to finish it, also for standardization of all the file names in that route
Added a helper for the percentage difference calculation in the src/util/helperfunctions.ts file
Finally I did an small refactor in the addBuffPrice function and added the percentage difference result next to the buff price
Fixed a case where the reference price was 0 because of no listed items or no active buy orders on certain items causing inconsistencies in price calculations, now it should display N/A when this happens, could be changed to anything else

dduart3 commented 1 year ago

Thank you for your contribution, great changes so far!

As with many other features, I would love to keep this an optional setting, as screen clustering has been one of our main issues in the past development process. If you know how, feel free to create a new extension setting under the "PRICES" section in the CSFloat tab of the popup which has to be enabled for the percentages to show. Otherwise, I can also commit this change to your PR myself.

Furthermore please review my one code comment, although this seems basically ready to merge, great work!

I was thinking about that honestly before but I forget about it while submitting the PR, sure I will do it rn

dduart3 commented 1 year ago

Thank you for your contribution, great changes so far!

As with many other features, I would love to keep this an optional setting, as screen clustering has been one of our main issues in the past development process. If you know how, feel free to create a new extension setting under the "PRICES" section in the CSFloat tab of the popup which has to be enabled for the percentages to show. Otherwise, I can also commit this change to your PR myself.

Furthermore please review my one code comment, although this seems basically ready to merge, great work!

did this and tested it already! feel free to modify it