Closed alxcar closed 8 months ago
Another great find! It seems like I missed a lot of stuff when adapting to CSFloat's currency conversion update.
Also opened an issue to create a tooltip to explain the data behind the sp% (should be easy to do whenever I finally integrate a front-end framework).
Fixed a bug where the SP% was significantly inaccurate for every currency other than USD. The current implementation used the display price on float, regardless of its currency:
It also compared it to price values in USD, if it was even able to extract the number correctly. This issue applied to all instances of the SP container (popout, sales history, etc.), leading to discrepancies between currencies:
The proposed solution involves dividing the user's local currency by its rate vs USD, ensuring it matches Buff's USD price:
While the SP% in the sales history is still somewhat inaccurate (as it occasionally compares months-old transactions in today's market), it will now hold true regardless of the user's currency: