search

GOMC-WSU / MoSDeF-dihedral-fit

MoSDeF-dihedral-fit: A simple software package to fit dihedrals via the MoSDeF software
MIT License
3 stars 5 forks source link

Suggestion : Tests #98

Closed naik-aakash closed 2 months ago

naik-aakash commented 3 months ago

Part of JOSS review : https://github.com/openjournals/joss-reviews/issues/6970

Dear developers,

I feel it would be great if tests are added to check for exceptions raised as well. From the current coverage report , I see most of the missing lines are from exceptions and would be better to have tests for these lines as well.

Screenshot 2024-07-19 200817

daico007 commented 2 months ago

Hi @naik-aakash, I have added more tests specifically on the exceptions raised in our main code in #106 and #120. Please let us know if you think if there's any area that we missed and needed more testing.

bc118 commented 2 months ago

I will add that some of the missing coverage parts in code that I write come from “catch all” checks; in which case, I do not know how the code would end up in that error or warning. However, if someone makes an error in the code, something that changes in in unexpected ways or allows the user to enter problematic options, it may catch some of these conditions.

bc118 commented 2 months ago

Closing as reviewer provided thumbs up on the added tests and general “catch all” checks that are hard to replicate.

More notes on this and other Reviewer Requests (provided as Issues) are located here https://github.com/GOMC-WSU/MoSDeF-dihedral-fit/issues/101