feature group selection button

JenkeScheen commented 3 years ago

implemented a "Save Group" and enabled multiselect : true in visjs code such that now:

you can select multiple nodes by either long-clicking or CMD+click or Ctrl+click (Mac/ non-Mac, resp.)
with 1 or more nodes selected, clicking "Save Group" button:
- prompts user with message and box to input group name
- if user clicks OK without inputting a string the prompt reappears (will disappear when clicking Cancel)
- if user clicks OK with a string for group name, saves the list of selected node IDs as well as the group name to variable (to be handled by Q later as with PR #3
if "Save Group" button is clicked without selecting any nodes, alert the user that nodes have to selected first

Bonus: fixed bug that @esguerra ran into that while editing an edge connectivity you can connect the edge to its own starting node. DisablededitEdge to handle this -> we don't want the user to be able to move edges across the network anyway because in this way edge information (such as ddG) is also transferred across the network.

xbello commented 3 years ago

I really don't want to sound like a nitpicker here, I like the work done.

But, any particular reason to not use the bootstrap modals (https://getbootstrap.com/docs/4.0/components/modal/) or alerts (https://getbootstrap.com/docs/4.0/components/alerts/), and use instead the javascript "alert"?

JenkeScheen commented 3 years ago

no reason really, just ignorance. will patch this when I find the time!

xbello commented 3 years ago

Don't worry, I'll do it. Just didn't want to mess with your work.

JenkeScheen commented 3 years ago

Great, thanks! Learning something new every day..

hteran commented 3 years ago

👍👏👏

Sent from my Huawei phone

-------- Original message -------- From: Xabier Bello @.> Date: Tue, 20 Apr 2021, 19:18 To: GPCR-ModSim/qfepweb @.> Cc: Subscribed @.***> Subject: Re: [GPCR-ModSim/qfepweb] feature group selection button (#4)

Don't worry, I'll do it. Just didn't want to mess with your work.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/GPCR-ModSim/qfepweb/pull/4#issuecomment-823460149, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABU6HHRGLABEJB6T5WSOUTLTJWZNJANCNFSM43IEUVYQ.

När du har kontakt med oss på Uppsala universitet med e-post så innebär det att vi behandlar dina personuppgifter. För att läsa mer om hur vi gör det kan du läsa här: http://www.uu.se/om-uu/dataskydd-personuppgifter/

E-mailing Uppsala University means that we will process your personal data. For more information on how this is performed, please read here: http://www.uu.se/en/about-uu/data-protection-policy

xbello commented 3 years ago

Done.

GPCR-ModSim / qfepweb

feature group selection button #4