search

GPCsolutions / dolibarr

Dolibarr ERP/CRM is a modern software to manage your company or foundation activity (contacts, suppliers, invoices, orders, stocks, agenda, ...).It's an opensource software (wrote with PHP language) designed for small and medium companies, foundation and freelances. You can freely install, use and distribute it as a standalone application or as a web application to use it from every internet access and media.
http://www.dolibarr.org
GNU General Public License v3.0
2 stars 0 forks source link

Projects #69

Closed marcosgdf closed 9 years ago

marcosgdf commented 9 years ago

Travis reports some errors by PHPCS regarding camelCase of load_board which I can't fix

rdoursenaud commented 9 years ago

Couldn't fault you apart on 2 mixed tabs and spaces lines. Great job !

rdoursenaud commented 9 years ago

I merged your changes to our own branch at https://github.com/GPCsolutions/dolibarr/tree/3.6-projectsenhancements.

Would your mind fixing the few issues (Missing property declarations for the most part) revealed by scrutinizer at https://scrutinizer-ci.com/g/GPCsolutions/dolibarr/inspections/c414adc2-df85-4c39-94eb-747808462633 ?

marcosgdf commented 9 years ago

@rdoursenaud I saw them but I'm afraid we're not allowed to do anything but fixes in any branch other than develop... property declarations are because they are not part of the class. Might do some PR to change this in the future 3.8...

rdoursenaud commented 9 years ago

@marcosgdf Ok, no problem. I just wanted to make sure you were aware.

rdoursenaud commented 9 years ago

I have two strange bugs in the "current" task page.

I don't have time to look into it. Could you please have a quick glance to tell me if I'm right?

Thanks

marcosgdf commented 9 years ago

No, it takes task affectation but the project visibility must be set to "everybody" in order to show tasks for people not affected to the project.

I send a new PR correcting a little bug I found.

rdoursenaud commented 9 years ago

Thanks.

If that's how it works, the logic in this project module is completely flawed. A fucking task contact IS part of the project 'cause the task IS what makes a project.

Sorry for the strong language, it's not directed towards you, you did an amazing job. I just had to get it out…

I'll try to enjoy my week-end and do more testing and a bug report on monday.

marcosgdf commented 9 years ago

I know I know, don't worry.

I think all the module has to be reviewed because it is actually a mess just to list tasks and projects...

rdoursenaud commented 9 years ago

Thanks, another weirdness we just discovered is occuring in the project and tasks alerts.

If the delay is set to 0 days, no alert is ever shown. We expect these to show immediately with this setting.

Could you please look into it.

marcosgdf commented 9 years ago

Done