search

GPHemsley / tiff-js

A JavaScript-based parser for the TIFF image format.
Mozilla Public License 2.0
71 stars 30 forks source link

Fixes to tiff.js to work in Chrome #10

Closed city41 closed 11 years ago

city41 commented 11 years ago

Thanks for making tiff.js, it's been a great help for a project I am working on. I had to make some minor changes to get it to work in Chrome. Chrome does not like const in strict mode (since it's not yet part of the standard), and Chrome does not support default parameters (which is a Firefox proprietary feature).

GPHemsley commented 11 years ago

Great, thanks!

GPHemsley commented 11 years ago

I've pretty much undone commit 9a9291f with commit 9d6e3c5.

I generally test the script with by refreshing with a file already loaded, so having the onload trigger would prompt the image to be reparsed on refresh, instead of me having to manually reload the image.

I also changed the default background color to something that is a little more obvious (#FFEEFF). Having it solid black could lead to confusion as whether an image was parsed correctly, if an image actually has a lot of black in it. Along those lines, I've also (in commit f1ad327) made it so that the canvas border changes from dashed to solid when the image is loaded.

Hopefully these changes will satisfy the same usecase requirements as your original commit.