GPSBabel / gpsbabel

GPSBabel: convert, manipulate, and transfer data from GPS programs or GPS receivers. Open Source and supported on MacOS, Windows, Linux, and more. Pointy clicky GUI or a command line version...
https://www.gpsbabel.org
GNU General Public License v2.0
477 stars 127 forks source link

Remove final remnants of 'exported' #1146

Closed tsteven4 closed 1 year ago

tsteven4 commented 1 year ago

I think this is what was meant to be in #1145.

codacy-production[bot] commented 1 year ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% 100.00%
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (dfc770ac0a68a0827f89ddf8ef09c5766f16a53c) | 23087 | 16008 | 69.34% | | | Head commit (e2eb8f463a549cbc0e63f4c50d1e201992269300) | 23068 (-19) | 15989 (-19) | 69.31% (**-0.02%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#1146) | 1 | 1 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

tsteven4 commented 1 year ago

In duplicate.cc, the comment "It looks odd ..." relates to the deleted sort and should also be deleted.

tsteven4 commented 1 year ago

@robertlipe please take ownership of this PR, it's all your work that accidentally got into #1144 which I removed before merging.

tsteven4 commented 1 year ago

@robertlipe can we kill #1145 and merge this? I resolved all my issues.

robertlipe commented 1 year ago

Indeed. I made a mess fo that. Sorry for hte buy work. I'll to set fire to 1144 right now.