search

GPSBabel / gpsbabel

GPSBabel: convert, manipulate, and transfer data from GPS programs or GPS receivers. Open Source and supported on MacOS, Windows, Linux, and more. Pointy clicky GUI or a command line version...
https://www.gpsbabel.org
GNU General Public License v2.0
475 stars 126 forks source link

fix SchemaArrayField/SchemaArrayData mismatch #1177

Closed tsteven4 closed 1 year ago

tsteven4 commented 1 year ago

related to IGC additions from #1060 and #1054.

tsteven4 commented 1 year ago

@PacketFiend this does not differ from tsteven4:kmlaccumulate you looked at yesterday, but the history reflects the merge of #1060. It is a draft as I want to clean things up a bit.

tsteven4 commented 1 year ago

@robertlipe I intend to remove global_trait traits. The only usage was kml, and the kml usage for multitrack is specific only to track points or, for geoache, only to waypoints.

GPSBabelDeveloper commented 1 year ago

I've lost the beat (traveling/vacation) but the reason I added the 'traits' stuff was so that we could amortize the cost of figuring out what kind of stuff we have that might require a preamble during add instead of making a pass over the entire waypoint/track list. That was we could decide whether to write the geocache or track template in the KML header without actually scanning the whole list to find the presence/absence of these things.

If you've found a way around this that's performant enough to meet your high standards, I won't weep.

RJL

On Thu, Sep 14, 2023 at 7:54 AM tsteven4 @.***> wrote:

Merged #1177 https://github.com/GPSBabel/gpsbabel/pull/1177 into master.

— Reply to this email directly, view it on GitHub https://github.com/GPSBabel/gpsbabel/pull/1177#event-10371978631, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3VAD3YQKA4GJTM6UJWC6TX2L5BXANCNFSM6AAAAAA4UYKBYM . You are receiving this because you are subscribed to this thread.Message ID: @.***>