Closed tsteven4 closed 9 months ago
Good call. This part is the code has had a hard life.
On Mon, Nov 13, 2023, 8:50 AM tsteven4 @.***> wrote:
use using for jeeps function pointers.
const correctness for GPS_PPacket use. The important bit here is in gpssend.cc, Build_Serial_Packet used to receive a 1KB packet by copy, now it is by const reference.
original jeeps used GPS_SXXX, GPS_OSXXX, GPS_PXXX for the structure tag, a typedef of the structure, and a pointer to a typedef of the structure. In the case of GPS_PPacket this convention was no longer followed. rename GPS_PPacket -> GPS_Packet.
GPSSerial[SOP]Packet -> GPS_Serial_Packet, GPS_Serial_Packet*.
You can view, comment on, or merge this pull request online at:
https://github.com/GPSBabel/gpsbabel/pull/1215 Commit Summary
- 1700c59 https://github.com/GPSBabel/gpsbabel/pull/1215/commits/1700c59dac3e747d208a49453d57105ec3e55f7c use using for jeeps function prototypes.
- c90bb2c https://github.com/GPSBabel/gpsbabel/pull/1215/commits/c90bb2c5c9bd06f62753545f82b9ec417ddbf279 const correctness wrt GPS_PPacket.
- 82797a9 https://github.com/GPSBabel/gpsbabel/pull/1215/commits/82797a961f608f0b63ff21c71650fc9314145e66 delete accidentally committed file.
- 1804cdd https://github.com/GPSBabel/gpsbabel/pull/1215/commits/1804cddc9cbaff8a8bf862e7f154e15848f5142b rename GPS_PPacket -> GPS_Packet.
- 9a5e5b2 https://github.com/GPSBabel/gpsbabel/pull/1215/commits/9a5e5b2fdc7c73b85162c233422aa7b27c349dc8 change GPS_Packet back to a structure.
- 2bb5543 https://github.com/GPSBabel/gpsbabel/pull/1215/commits/2bb5543728886ba250d55f6688f538c2b426dc3d try harder to change GPS_Packet back to a struct.
- c46e66e https://github.com/GPSBabel/gpsbabel/pull/1215/commits/c46e66e22199417d0126abf590a1cd64bbac45c7 clean up GPSSerial[SOP]Packet.
- 04e45de https://github.com/GPSBabel/gpsbabel/pull/1215/commits/04e45dee295a95197849a4517bec5558261c0f37 catch some missed renames up.
File Changes
(17 files https://github.com/GPSBabel/gpsbabel/pull/1215/files)
- M jeeps/gps.h https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-8ca87741b6db3339db5c825827da730911bac03ed0cdb536ca5d27cb98b44066 (23)
- M jeeps/gpsapp.cc https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-e192ae85322b3c91fef63752fd1b705f09e9fc0a0c6451ac13fa389dfb78ce26 (170)
- M jeeps/gpsapp.h https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-f53b978845836ae379e0abf80b3b22dacc7e80ad59ee164244f3ddf7b790fa73 (10)
- M jeeps/gpscom.cc https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-46a82d93690548f74659212096d75f85d12ff846927f4967bc43753a1ccf3b70 (4)
- M jeeps/gpsdevice.cc https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-deddcfe1d50ab211be150b0e9b77fc9a5ced3f285acdbcf5b45fe96860328f28 (10)
- M jeeps/gpsdevice.h https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-c399ed46332feaf15ff54d727cee72662d3735996fe326bad96f4d91cacf5c38 (21)
- M jeeps/gpsdevice_usb.cc https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-06be6130248db580780bb29462d7ae430a40b4a795bb7d63f70a5ef80128f0ba (2)
- M jeeps/gpsread.cc https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-663df81ea3db66ed2dc6720442a5c0966f3a80cbde3deacf5a37fae9152babf4 (10)
- M jeeps/gpsread.h https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-8b9e7f740e2a2c4aa412eed6436b1fd571533a493067feb0a3c3a053c14bb594 (4)
- M jeeps/gpsrqst.cc https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-7b03907b15a23f1403affafd40f049fcf57ea87ae0d5dc5eb8abbe68cb03d280 (8)
- M jeeps/gpssend.cc https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-a6e716e1c312704c6fca6ceb06b69b88f695decd2f78d741de3abf235cda8922 (20)
- M jeeps/gpssend.h https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-d35d191d889de277be7807a227e206b8168bb8b7a591d8a431e043fcfa108835 (6)
- M jeeps/gpsserial.cc https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-1f03faae128f7b00b079d18e5e02086fdf4c0d79f5e8a851c3c67e948cb8049f (8)
- M jeeps/gpsusbcommon.h https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-4edfa99d994ea339575170e43f2d4fb4ba973d1731f30238974264da5437978b (6)
- M jeeps/gpsusbint.h https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-83929ef0cf7d55b1e5509750b61c0887c36610d71499668db61c11861952e678 (6)
- M jeeps/gpsusbread.cc https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-3b299a7fc21fea584daa26575767c2c96079b12a9aaaafccb43cc5b17fb20856 (2)
- M jeeps/gpsusbsend.cc https://github.com/GPSBabel/gpsbabel/pull/1215/files#diff-fb418b8b9b9738a555a15297d2d3f64465bf310717c2f93569aba8a7cdbe4d40 (2)
Patch Links:
- https://github.com/GPSBabel/gpsbabel/pull/1215.patch
- https://github.com/GPSBabel/gpsbabel/pull/1215.diff
— Reply to this email directly, view it on GitHub https://github.com/GPSBabel/gpsbabel/pull/1215, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCSD3YRISJU7M4MOGVOFPDYEIXUTAVCNFSM6AAAAAA7JIYBM6VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TAOBRHAYTMNY . You are receiving this because you are subscribed to this thread.Message ID: @.***>
use using for jeeps function pointers.
const correctness for GPS_PPacket use. _The important bit here is in gpssend.cc, Build_SerialPacket used to receive a 1KB packet by copy, now it is by const reference.
original jeeps used GPS_SXXX, GPS_OSXXX, GPS_PXXX for the structure tag, a typedef of the structure, and a pointer to a typedef of the structure. In the case of GPS_PPacket this convention was no longer followed. rename GPS_PPacket -> GPS_Packet.
GPSSerial[SOP]Packet -> GPS_Serial_Packet, GPS_Serial_Packet*.