search

GPSBabel / gpsbabel

GPSBabel: convert, manipulate, and transfer data from GPS programs or GPS receivers. Open Source and supported on MacOS, Windows, Linux, and more. Pointy clicky GUI or a command line version...
https://www.gpsbabel.org
GNU General Public License v2.0
470 stars 125 forks source link

jeeps function pointers, GPS_PPacket const correctness, GPS_Serial_[OSP]Packet -> GPS_Serial_Packet #1215

Closed tsteven4 closed 9 months ago

tsteven4 commented 9 months ago

use using for jeeps function pointers.

const correctness for GPS_PPacket use. _The important bit here is in gpssend.cc, Build_SerialPacket used to receive a 1KB packet by copy, now it is by const reference.

original jeeps used GPS_SXXX, GPS_OSXXX, GPS_PXXX for the structure tag, a typedef of the structure, and a pointer to a typedef of the structure. In the case of GPS_PPacket this convention was no longer followed. rename GPS_PPacket -> GPS_Packet.

GPSSerial[SOP]Packet -> GPS_Serial_Packet, GPS_Serial_Packet*.

robertlipe commented 9 months ago

Good call. This part is the code has had a hard life.

On Mon, Nov 13, 2023, 8:50 AM tsteven4 @.***> wrote:

use using for jeeps function pointers.

const correctness for GPS_PPacket use. The important bit here is in gpssend.cc, Build_Serial_Packet used to receive a 1KB packet by copy, now it is by const reference.

original jeeps used GPS_SXXX, GPS_OSXXX, GPS_PXXX for the structure tag, a typedef of the structure, and a pointer to a typedef of the structure. In the case of GPS_PPacket this convention was no longer followed. rename GPS_PPacket -> GPS_Packet.

GPSSerial[SOP]Packet -> GPS_Serial_Packet, GPS_Serial_Packet*.

You can view, comment on, or merge this pull request online at:

https://github.com/GPSBabel/gpsbabel/pull/1215 Commit Summary

File Changes

(17 files https://github.com/GPSBabel/gpsbabel/pull/1215/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/GPSBabel/gpsbabel/pull/1215, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCSD3YRISJU7M4MOGVOFPDYEIXUTAVCNFSM6AAAAAA7JIYBM6VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TAOBRHAYTMNY . You are receiving this because you are subscribed to this thread.Message ID: @.***>