search

GPSBabel / gpsbabel

GPSBabel: convert, manipulate, and transfer data from GPS programs or GPS receivers. Open Source and supported on MacOS, Windows, Linux, and more. Pointy clicky GUI or a command line version...
https://www.gpsbabel.org
GNU General Public License v2.0
470 stars 125 forks source link

use c++11 fixed width integer types in jeeps. #1217

Closed tsteven4 closed 9 months ago

tsteven4 commented 9 months ago

thanks resharper, it just took a little preparation and help with non-widows code.

tsteven4 commented 9 months ago

any reason not to do these as well?

typedef unsigned char UC;
typedef uint16_t      US;
robertlipe commented 9 months ago

If it's easy, go for it's please.

On Tue, Nov 14, 2023, 9:13 AM tsteven4 @.***> wrote:

any reason not to do these as well?

typedef unsigned char UC; typedef uint16_t US;

— Reply to this email directly, view it on GitHub https://github.com/GPSBabel/gpsbabel/pull/1217#issuecomment-1810426337, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCSD33G2QXKSSLQM544ZWTYEODBDAVCNFSM6AAAAAA7K6PFX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJQGQZDMMZTG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

tsteven4 commented 9 months ago

It is quite easy to do an "inline" refactoring of a typedef like these. However, the refactoring isn't offered for the equivalent using statement.

In any event I am going to postpone inlining of UC and US to finish some other work.