GPSBabel / gpsbabel

GPSBabel: convert, manipulate, and transfer data from GPS programs or GPS receivers. Open Source and supported on MacOS, Windows, Linux, and more. Pointy clicky GUI or a command line version...
https://www.gpsbabel.org
GNU General Public License v2.0
452 stars 125 forks source link

support builds with shapelib (as documented). #1268

Closed tsteven4 closed 2 months ago

tsteven4 commented 3 months ago

we document the ability to build without shapelib:

GPSBABEL_WITH_SHAPELIB:STRING=no|pkgconfig|included*|custom
  no: build without shapelib.  functionality will be limited.

This is supported in shapelib.cmake, but CMakeLists.txt defeats this functionality by always defining SHAPELIB_ENABLED.

robertlipe commented 3 months ago

There was a time I cared about requiring libs of many hundreds of bytes.

That time has past. Maybe we just say we require what we require and quit fretting over the combinations.

A one-line fix isn't exactly the breaking point. I'm just saying that in the future (the current) let's not worry much about this kind of thing. I'd rather have one build that works really well than six builds that support different subsets of $THINGS.