GPSBabel / gpsbabel

GPSBabel: convert, manipulate, and transfer data from GPS programs or GPS receivers. Open Source and supported on MacOS, Windows, Linux, and more. Pointy clicky GUI or a command line version...
https://www.gpsbabel.org
GNU General Public License v2.0
475 stars 126 forks source link

update macos release to Qt 6.5.3 #1284

Closed tsteven4 closed 4 months ago

tsteven4 commented 4 months ago

This avoids warnings for our release build on macos with Qt 6.2.4 like:

CMake Warning at /Users/runner/Cache/Qt/6.2.4/macos/lib/cmake/Qt6/FindWrapOpenGL.cmake:41 (target_link_libraries):
-- Generating done (0.0s)
  Target "gpsbabelfe" requests linking to directory
-- Build files have been written to: /Users/runner/work/gpsbabel/gpsbabel
  "/Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/System/Library/Frameworks".
  Targets may link only to libraries.  CMake is dropping the item.
Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.29.3/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
  /Users/runner/Cache/Qt/6.2.4/macos/lib/cmake/Qt6Gui/Qt6GuiDependencies.cmake:48 (find_dependency)
  /Users/runner/Cache/Qt/6.2.4/macos/lib/cmake/Qt6Gui/Qt6GuiConfig.cmake:40 (include)
  /Users/runner/Cache/Qt/6.2.4/macos/lib/cmake/Qt6/Qt6Config.cmake:209 (find_package)
  gui/CMakeLists.txt:25 (find_package)
codacy-production[bot] commented 4 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.01% :white_check_mark:
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (ed07a180a0781e49ac033ba59e4930abfa3747b3) | 27614 | 17205 | 62.31% | | | Head commit (ef3e932c8b21dc6db29e1e87859495c04a7f121d) | 55237 (+27623) | 34419 (+17214) | 62.31% (**+0.01%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#1284) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

tsteven4 commented 4 months ago

NOTE: This raises drops macOS 10.14 & 10.15. The floor with Qt 6.5 is macOS 11.

robertlipe commented 4 months ago

Live by the sword. Die by the sword. My 2012 iMac (10.15) is increasingly struggling with life anyway. Local builds are find and CI will catch anything I do there that's not hip with 6.5.

I'm OK with this. Thanx for updating it.

On Wed, Jun 5, 2024 at 8:36 AM tsteven4 @.***> wrote:

NOTE: This raises drops macOS 10.14 & 10.15. The floor with Qt 6.5 is macOS 11.

— Reply to this email directly, view it on GitHub https://github.com/GPSBabel/gpsbabel/pull/1284#issuecomment-2149961444, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCSD3ZCUOSZD23LRNZOVT3ZF4H7JAVCNFSM6AAAAABI2XIF6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBZHE3DCNBUGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>